Text archives Help

---

It is merely a tradeoff. Some of them were turned on at my request because I was tired of having the basic things not work. It is not that difficult for people to turn off the scenes if they do not want them, but they will then bear the responsibility of committing bad code.

A few of them do not need to be on (they were probably just cut/ paste), but I think that most of them should be on. In fact, I might go as far to say that anything that 1) does not take an excessively long (minutes) time to compile, and 2) does not require special libraries to be installed (like swig) should be on by default. Everyone should bear the responsibility of making sure that their changes work under those configurations even if they disable them by default.

Steve


On Jan 28, 2008, at 5:01 PM, Thiago Ize wrote:

Oh, forgot to mention. If they are off by default, then at least the default build won't break for people. That's still not acceptable, but at least only 1 or 2 people would complain (those who actually use those scenes).

Thiago

Thiago Ize wrote:

Well, I keep turning them off (as well as swig), so at least I would still commit bad code (this is of course all hypothetical since we all know my code is perfection ;-) . If you want to prevent people from breaking builds, then you need to make it so that those scenes can't be disabled or we should implement some of the other suggestions you mention.

Thiago

PS: I didn't know about make Experimemental, I'll try and use that.

Solomon Boulos wrote:

The point of having these on was to make people stop breaking the build. If we want to have these off by default, then we probably need a continuous build system with error messages going to the list or people need to run:

make Experimental

Before every commit (unlikely). The goal was that having them enabled by default would basically make the default case a better one for manta build breakage (much less often these days). People with machines to offer, can we setup more machines to auto-build Manta or is this overkill?

On Jan 28, 2008, at 3:51 PM, thiago@sci.utah.edu wrote:

Author: thiago
Date: Mon Jan 28 16:51:39 2008
New Revision: 2012

Modified:
  trunk/scenes/CMakeLists.txt
Log:
Making most of the scenes off by default. Most users will not use
these test scenes, and compiling them takes time (and lately I've been
recompiling from scratch quite a bit). If you need it, you can of
course turn it on in ccmake. As far as I know, only the
trianglesceneviewer is used by most people, so I left that on. If I
disabled a scene that should be enabled by default, feel free to undo
my change.


Modified: trunk/scenes/CMakeLists.txt
=================================================================== ===========
--- trunk/scenes/CMakeLists.txt    (original)
+++ trunk/scenes/CMakeLists.txt    Mon Jan 28 16:51:39 2008
@@ -9,49 +9,49 @@
  )

# Basic test scene.
-SET(SCENE_0 TRUE CACHE BOOL "Scene 0")
+SET(SCENE_0 FALSE CACHE BOOL "Scene 0")
IF(SCENE_0)
   ADD_LIBRARY(scene_0 0.cc)
   TARGET_LINK_LIBRARIES(scene_0 ${MANTA_SCENE_LINK})
ENDIF(SCENE_0)

# Test different primitives.
-SET(SCENE_PRIMTEST TRUE CACHE BOOL "Primitive Test")
+SET(SCENE_PRIMTEST FALSE CACHE BOOL "Primitive Test")
IF(SCENE_PRIMTEST)
   ADD_LIBRARY(scene_primtest primtest.cc)
   TARGET_LINK_LIBRARIES(scene_primtest ${MANTA_SCENE_LINK})
ENDIF(SCENE_PRIMTEST)

# Test acceleration structure efficiency through random objects
-SET(SCENE_COMPLEXITYTEST TRUE CACHE BOOL "Complexity Test")
+SET(SCENE_COMPLEXITYTEST FALSE CACHE BOOL "Complexity Test")
IF(SCENE_COMPLEXITYTEST)
   ADD_LIBRARY(scene_complexitytest complexitytest.cc)
   TARGET_LINK_LIBRARIES(scene_complexitytest ${MANTA_SCENE_LINK})
ENDIF(SCENE_COMPLEXITYTEST)

# Old RTRT teapot scene
-SET(SCENE_TEAPOT_ROOM TRUE CACHE BOOL "Old RTRT teapot scene")
+SET(SCENE_TEAPOT_ROOM FALSE CACHE BOOL "Old RTRT teapot scene")
IF(SCENE_TEAPOT_ROOM)
   ADD_LIBRARY(scene_teapotRoom teapotRoom.cc)
   TARGET_LINK_LIBRARIES(scene_teapotRoom ${MANTA_SCENE_LINK})
ENDIF(SCENE_TEAPOT_ROOM)

# softshadow via many point sources
-SET(SCENE_SOFT_SHADOW TRUE CACHE BOOL "Soft Shadow test")
+SET(SCENE_SOFT_SHADOW FALSE CACHE BOOL "Soft Shadow test")
IF(SCENE_SOFT_SHADOW)
   ADD_LIBRARY(scene_softshadow softshadow.cc)
   TARGET_LINK_LIBRARIES(scene_softshadow ${MANTA_SCENE_LINK})
ENDIF(SCENE_SOFT_SHADOW)

# instances of fences
-SET(SCENE_FENCE TRUE CACHE BOOL "Soft Shadow test")
+SET(SCENE_FENCE FALSE CACHE BOOL "fence test")
IF(SCENE_FENCE)
   ADD_LIBRARY(scene_fence fence.cc)
   TARGET_LINK_LIBRARIES(scene_fence ${MANTA_SCENE_LINK})
ENDIF(SCENE_FENCE)

# hdri lit scene
-SET(SCENE_HDRI TRUE CACHE BOOL "HDRI test")
+SET(SCENE_HDRI FALSE CACHE BOOL "HDRI test")
IF(SCENE_HDRI)
   ADD_LIBRARY(scene_hdri hdritest.cc)
   TARGET_LINK_LIBRARIES(scene_hdri ${MANTA_SCENE_LINK})
@@ -127,14 +127,13 @@
ENDIF(SCENE_AREA_LIGHT)

# macbeth color checker scene
-SET(SCENE_MACBETH TRUE CACHE BOOL "Macbeth test")
+SET(SCENE_MACBETH FALSE CACHE BOOL "Macbeth test")
IF(SCENE_MACBETH)
   ADD_LIBRARY(scene_macbeth macbeth.cc)
   TARGET_LINK_LIBRARIES(scene_macbeth ${MANTA_SCENE_LINK})
ENDIF(SCENE_MACBETH)

-# macbeth color checker scene
-SET(SCENE_EXTERNAL_OBJECT TRUE CACHE BOOL "Externally derived object unit test")
+SET(SCENE_EXTERNAL_OBJECT FALSE CACHE BOOL "Externally derived object unit test")
IF(SCENE_EXTERNAL_OBJECT)
   ADD_LIBRARY(scene_externalObject externalObject.cc)
   TARGET_LINK_LIBRARIES(scene_externalObject ${MANTA_SCENE_LINK})

---

• [Manta] r2012 - trunk/scenes, thiago, 01/28/2008
  • Re: [Manta] r2012 - trunk/scenes, Solomon Boulos, 01/28/2008
    • Re: [Manta] r2012 - trunk/scenes, Thiago Ize, 01/28/2008
      • Re: [Manta] r2012 - trunk/scenes, Thiago Ize, 01/28/2008
        • Re: [Manta] r2012 - trunk/scenes, Steven G. Parker, 01/28/2008
          • Re: [Manta] r2012 - trunk/scenes, Thiago Ize, 01/28/2008
            • Re: [Manta] r2012 - trunk/scenes, Solomon Boulos, 01/28/2008

---

Archive powered by MHonArc 2.6.16.