Text archives Help

---

Hi,

Does anyone else try to compile Manta with GCC 4.3 in Fedora 9? GCC 4.3
is more strict about syntax and things so the current SVN does not build
at all. Here is a patch that fix some of the errors. There are still 
tons warnings (mostly about SSE) that need to be fixed.

BTW, what is official coding style including C header file in C++ code?
Do you #include <stdlib.h> or #include<cstdlib>?

Ollie

Index: Doxyfile
===================================================================
--- Doxyfile	(revision 2313)
+++ Doxyfile	(working copy)
@@ -242,7 +242,7 @@
 #---------------------------------------------------------------------------
 CLASS_DIAGRAMS         = NO
 HIDE_UNDOC_RELATIONS   = YES
-HAVE_DOT               = NO
+HAVE_DOT               = YES
 CLASS_GRAPH            = YES
 COLLABORATION_GRAPH    = YES
 GROUP_GRAPHS           = YES
Index: Core/Persistent/XMLArchive.cc
===================================================================
--- Core/Persistent/XMLArchive.cc	(revision 2313)
+++ Core/Persistent/XMLArchive.cc	(working copy)
@@ -8,6 +8,7 @@
 #include <map>
 #include <sstream>
 #include <string>
+#include <cstring>
 
 using namespace Manta;
 using namespace std;
Index: Core/Exceptions/ErrnoException.cc
===================================================================
--- Core/Exceptions/ErrnoException.cc	(revision 2313)
+++ Core/Exceptions/ErrnoException.cc	(working copy)
@@ -43,6 +43,7 @@
 #include <Core/Exceptions/ErrnoException.h>
 #include <sstream>
 #include <iostream>
+#include <cstring>
 
 namespace Manta {
 
Index: Core/Thread/Time_unix.cc
===================================================================
--- Core/Thread/Time_unix.cc	(revision 2313)
+++ Core/Thread/Time_unix.cc	(working copy)
@@ -50,6 +50,7 @@
 #ifdef __linux
 #include <time.h>
 #endif
+#include <cstring>
 
 static bool initialized=false;
 static struct timeval start_time;
Index: Core/Thread/Thread_pthreads.cc
===================================================================
--- Core/Thread/Thread_pthreads.cc	(revision 2313)
+++ Core/Thread/Thread_pthreads.cc	(working copy)
@@ -88,6 +88,7 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string>
+#include <cstring>
 #include <unistd.h>
 #include <fstream>
 #include <string>
Index: Core/Math/KorobovRNG.h
===================================================================
--- Core/Math/KorobovRNG.h	(revision 2313)
+++ Core/Math/KorobovRNG.h	(working copy)
@@ -34,6 +34,7 @@
 #include <Core/Exceptions/InternalError.h>
 #include <Core/Math/SSEDefs.h>
 
+#include <climits>
 
 namespace Manta {
 
Index: Core/Geometry/ScalarTransform1D.h
===================================================================
--- Core/Geometry/ScalarTransform1D.h	(revision 2313)
+++ Core/Geometry/ScalarTransform1D.h	(working copy)
@@ -38,7 +38,7 @@
     inline int getLookupIndex(const LType value, const LType min_,
                               const LType max_) const {
       int idx=static_cast<int>((value - min_)/(max_ - min_)*results->size() - 1);
-      return Clamp(index, 0, results->size() - 1);
+      return Clamp(idx, 0, results->size() - 1);
     }
 
     inline RType lookup(const LType value, const LType min_,
Index: Core/Util/Args.cc
===================================================================
--- Core/Util/Args.cc	(revision 2313)
+++ Core/Util/Args.cc	(working copy)
@@ -3,6 +3,7 @@
 #include <Core/Exceptions/IllegalValue.h>
 #include <Core/Geometry/Vector.h>
 #include <Core/Color/ColorDB.h>
+#include <cstdlib>
 
 using namespace std;
 
Index: Core/Util/CPUTime.cc
===================================================================
--- Core/Util/CPUTime.cc	(revision 2313)
+++ Core/Util/CPUTime.cc	(working copy)
@@ -15,6 +15,9 @@
 # include <Core/Thread/Time.h>
 #endif
 
+#include <cstring>
+#include <cstdlib>
+
 using namespace Manta;
 
 static bool initialized=false;
Index: Core/Util/ThreadStorage.cc
===================================================================
--- Core/Util/ThreadStorage.cc	(revision 2313)
+++ Core/Util/ThreadStorage.cc	(working copy)
@@ -28,6 +28,7 @@
 
 #include <Core/Util/ThreadStorage.h>
 #include <Interface/Context.h>
+#include <cstdlib>
 
 using namespace Manta;
 
Index: Model/Groups/BSP/Geometry.cc
===================================================================
--- Model/Groups/BSP/Geometry.cc	(revision 2313)
+++ Model/Groups/BSP/Geometry.cc	(working copy)
@@ -2,6 +2,8 @@
 #include <Core/Geometry/AffineTransformT.h>
 #include <Model/Groups/BSP/aip.h>
 #include <set>
+#include <algorithm>
+
 using namespace std;
 
 namespace Manta {
Index: Model/Groups/BSP/Geometry.h
===================================================================
--- Model/Groups/BSP/Geometry.h	(revision 2313)
+++ Model/Groups/BSP/Geometry.h	(working copy)
@@ -70,7 +70,7 @@
   //The points in the face are ordered around the polygon.
   Point getOrderedFaceNormal(const Polygon& face);
 
-  void getOrthonormalBasis(const Point &v, Point &u, Point &v); 
+  void getOrthonormalBasis(const Point &v, Point &u, Point &w); 
 
   double getArea(const Polygon& face);
 
Index: Model/Materials/Volume.cc
===================================================================
--- Model/Materials/Volume.cc	(revision 2313)
+++ Model/Materials/Volume.cc	(working copy)
@@ -1,5 +1,5 @@
 #include <Model/Materials/Volume.h>
-
+#include <algorithm>
 using namespace std;
 
 namespace Manta
Index: Model/Primitives/OctreeVolume.cc
===================================================================
--- Model/Primitives/OctreeVolume.cc	(revision 2313)
+++ Model/Primitives/OctreeVolume.cc	(working copy)
@@ -13,6 +13,7 @@
 
 #include <Model/Primitives/OctreeVolume.h>
 #include <Core/Util/LargeFile.h>
+#include <cstring>
 
 using namespace Manta;
 
Index: Interface/AccelerationStructure.h
===================================================================
--- Interface/AccelerationStructure.h	(revision 2313)
+++ Interface/AccelerationStructure.h	(working copy)
@@ -2,6 +2,7 @@
 #define Manta_Interface_AccelerationStructure_h
 
 #include <Interface/Object.h>
+#include <string>
 
 namespace Manta {
 
Index: Interface/RayPacket.h
===================================================================
--- Interface/RayPacket.h	(revision 2313)
+++ Interface/RayPacket.h	(working copy)
@@ -49,6 +49,8 @@
 #endif
 #include <iosfwd>
 
+#include <cstring>
+
 namespace Manta {
   class Material;
   class RenderContext;
Index: tests/atomic_counter.cc
===================================================================
--- tests/atomic_counter.cc	(revision 2313)
+++ tests/atomic_counter.cc	(working copy)
@@ -39,6 +39,7 @@
 using std::cerr;
 #include <stdio.h>
 #include <stdlib.h>
+#include <cstring>
 
 #ifndef _WIN32
 #include <unistd.h>
Index: Engine/Control/RTRT.cc
===================================================================
--- Engine/Control/RTRT.cc	(revision 2313)
+++ Engine/Control/RTRT.cc	(working copy)
@@ -67,8 +67,8 @@
 
 #include <sstream>
 #include <iostream>
+#include <algorithm>
 
-
 #include <Interface/Material.h>
 
 #include <Core/Math/CheapRNG.h>
Index: Engine/Display/PureOpenGLDisplay.cc
===================================================================
--- Engine/Display/PureOpenGLDisplay.cc	(revision 2313)
+++ Engine/Display/PureOpenGLDisplay.cc	(working copy)
@@ -57,6 +57,7 @@
 
 #include <iostream>
 #include <typeinfo>
+#include <cstring>
 
 #ifdef __APPLE__
 // For some reason, apple has these extensions but doesn't have the proper

---

• [Manta] GCC 4.3 patch, Li-Ta Lo, 08/20/2008
  • [Manta] Re: GCC 4.3 patch, Abe Stephens, 08/20/2008
    • [Manta] Re: GCC 4.3 patch, Li-Ta Lo, 08/20/2008

---

Archive powered by MHonArc 2.6.16.