Text archives Help

---

That was my basic conclusion as well. I'll commit the files and you can take a look at the MMX stuff, which should probably be converted to SSE2. There's a third function that might be worth adding in there as well that computes the sine and the cosine simultaneously (since many applications want both anyway). I'll drop that in too before the commit.

~Austin

Solomon Boulos wrote:

Looks like you just need to maintain their licensing info but is otherwise free to use. One concern I have (w/o looking at the code) is that he mentions that he uses SSE + MMX instead of SSE2. This is usually considered a bad thing because the MMX instructions can mess with the floating point state. He mentions that his stuff is just based on some intel approximate math library that uses SSE2 so maybe you can merge the two instead (or just base it off the Intel library)

As far as placing it in the codebase, I think if you adapt something you should just say so and add it wherever you would have if you had implemented it from scratch. If (by some magic), we actually directly use something we should consider adding some sort of ThirdParty directory (or similar).



On Sep 12, 2007, at 8:18 AM, Austin Robison wrote:

In order to SSEify the ThinLensCamera I've adapted some SSE routines for sine and cosine from here: http://gruntthepeon.free.fr/ssemath/

This code is available under the zlib license (http://www.gzip.org/zlib/zlib_license.html)

I've placed my adapted routines in SSEDefs.h with the appropriate copyright/license statement proceeding them. Is this an accepted way to place this code within the codebase? Are there any issues with the MIT license?
Just wanted to ask before I committed the code. (The SSE version of the ThinLensCamera works great too.)

~Austin

---

• [Manta] License Question, Austin Robison, 09/12/2007
  • Re: [Manta] License Question, Solomon Boulos, 09/12/2007
    • Re: [Manta] License Question, Austin Robison, 09/12/2007
  • Re: [Manta] License Question, Steven G. Parker, 09/12/2007

---

Archive powered by MHonArc 2.6.16.